The thing is you should come out of hockey with at least those skills. It's a sport well known for discipline for non-conformism; being late or dogging it at a practice, even in junior hockey, gets you a suspension by the coach. I'm guessing they couldn't handle even that minimum level of order there.
If they wanted to keep playing hockey they probably could with a USports scholarship to a Canadian University. It's telling that they couldn't even get one of those (or an NCAA scholarship to a US school, though they would be ineligible if they actually ever played junior hockey in the OHL as the NCAA considers it a professional league) because they are given out like candy to Canadian hockey bros that fall short of making it to a pro-league,
even a minor league like the ECHL which is basically full of guys like this (three of their teams are in Florida!). I suspect they flaked out at hockey because they couldn't "1) Show Up 2) Listen and 3) Put in Effort."
First of all, that's a lot of presumptions about people that you don't know. A bit rude to be honest.
They are both very good at hockey. The younger is a lot better than the older.
My younger cousin was a top starter on a top OHL team. He was a top OHL draft pick, and is on an AHL team (not a starter yet). He was apparently invited to a prospect training camp for a NHL team for this year ... not sure when really. For him, I can understand how much of an emotional choice it is, because for a long time, it has looked like he has a legit shot at a professional career. This is also his potential draft year, so that is obviously on his mind. My worry for him is that he gets so tantalizing close, but then doesn't make it, and he has nothing to fall back on. At a minimum, he could be a starter in AHL or Europe IMO. Those things could lead him into a related career after hockey, assuming he picks up the education and skills necessary along the way.
The older brother is another story - he is good, but not as good as his younger. He went to OJHL. The fact that he wouldn't be able to go pro was evident a while ago, and he should have focused on a different path like USports or NCAA (as you say). His academics aren't great from what I know, so that could be an issue. He is currently in a college undergraduate, but seems lost and uninterested.
The problem is not their hockey skill. I suspect they show up, listen and put in effort when it comes to hockey. It was their whole life after all, and you wouldn't get to their levels without at least showing those things in the hockey setting.
The problem is they don't care about anything else.
Anyway, that's a lot of off-topic information. I guess what I am driving at is that there is value in having a job, i.e. between semesters in high school or college, even if just for the experience of having a job. The money might be paltry, and you might not even need it, but there is value is learning how to work for someone and with others, and all that entails. For better or worse, for most people, working is an essential part of being an adult. A lot of young people who forego that part-time work are missing out on that experience, and it certainly shows.